feat: allow webauthn info to be passed in wallet creation#8481
Open
weldon-bitgo wants to merge 1 commit intomasterfrom
Open
feat: allow webauthn info to be passed in wallet creation#8481weldon-bitgo wants to merge 1 commit intomasterfrom
weldon-bitgo wants to merge 1 commit intomasterfrom
Conversation
8900663 to
28d7c68
Compare
mohammadalfaiyazbitgo
requested changes
Apr 10, 2026
| } | ||
|
|
||
| userKeychainParams.reqId = reqId; | ||
| const newUserKeychain = await this.baseCoin.keychains().add(userKeychainParams); |
Contributor
There was a problem hiding this comment.
we need to update this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-8495
Description
This PR allows webauthn information to be passed during wallet creation. Ultimately, this enables passkeys to be added to wallets during wallet creation; otherwise, passkeys must be added to wallets after they have been created. This change will allow us to introduce an optional passkey addition step during the wallet creation process.
Issue Number
WP-8495
Type of change
How Has This Been Tested?
Two new test files are added for this change.
walletsWebauthn.tscontains unit tests forWallets.generateWalletand tests that:webauthnDevicesis populated with correct device metadata and PRF-encrypted private keywebauthnDevicesis omitted whenwebauthnInfois absent or no private key is availablegenerateWallet.tscontains Express route tests and tests that:webauthnInfothrough togenerateWalletand returns a status code of 200otpDeviceId,prfSalt, orpassphraseeach return a status code of 400Checklist: